Remove Stream Scopes #346
Merged
Remove Stream Scopes #346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mr3zee
commented
Jun 10, 2025
Comment on lines
+21
to
+28
| internal actual fun CoroutineScope.debugCoroutines() { | ||
| DebugProbes.install() | ||
| launch { | ||
| withContext(Dispatchers.IO) { | ||
| delay(10.seconds) | ||
| } | ||
| DebugProbes.dumpCoroutines() | ||
| } |
There was a problem hiding this comment.
Updated in a later PR in the series
e5l
approved these changes
Jun 11, 2025
Mr3zee
force-pushed
the
enforce-strict-mode
branch
from
2486265 to
d3ec360
Compare
Mr3zee
force-pushed
the
remove-stream-scopes
branch
from
126ec96 to
d9dc982
Compare
Mr3zee
added a commit
that referenced
this pull request
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strict mode Migration
A series of changes to simplify kRPC protocol
Subsystem
kRPC
Problem Description
Stream Scopes are deprecated
Solution
Remove stream scopes and adjust client and server capabilities to work with a simpler model.
Server streams are now only cold, client streams are limited by the request's scope.
CAUTION: not all tests pass. This is a partial implementation, some things fail due to lifetime model issues, will be address in a separate PR.