grpc: Add KMP sample project #474
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jozott00
commented
Sep 12, 2025
Comment on lines
+90
to
+99
| // TODO: What is the correct way to declare this dependency? | ||
| // (without it fails when executing "publishAllPublicationsToBuildRepository")" | ||
| val bufGenerateCommonMain = tasks.named("bufGenerateCommonMain") | ||
|
|
||
| tasks.withType<org.gradle.jvm.tasks.Jar>().configureEach { | ||
| // Only for sources jars | ||
| if (archiveClassifier.orNull == "sources" || name.endsWith("SourcesJar")) { | ||
| dependsOn(bufGenerateCommonMain) | ||
| } | ||
| } |
There was a problem hiding this comment.
@Mr3zee The source jar must define the dependency on bufGenerateCommonMain outputs, otherwise I get the following gradle error for all targets during publishAllPublicationsToBuildRepository.
> Task :protobuf:protobuf-core:bufGenerateCommonMain FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Some problems were found with the configuration of task ':protobuf:protobuf-core:bufGenerateCommonMain' (type 'BufGenerateTask').
- Gradle detected a problem with the following location: '/Users/johannes.zottele/IdeaProjects/kotlinx-rpc/protobuf/protobuf-core/src/commonMain/generated-code'.
Reason: Task ':protobuf:protobuf-core:macosX64SourcesJar' uses this output of task ':protobuf:protobuf-core:bufGenerateCommonMain' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.
Possible solutions:
1. Declare task ':protobuf:protobuf-core:bufGenerateCommonMain' as an input of ':protobuf:protobuf-core:macosX64SourcesJar'.
2. Declare an explicit dependency on ':protobuf:protobuf-core:bufGenerateCommonMain' from ':protobuf:protobuf-core:macosX64SourcesJar' using Task#dependsOn.
3. Declare an explicit dependency on ':protobuf:protobuf-core:bufGenerateCommonMain' from ':protobuf:protobuf-core:macosX64SourcesJar' using Task#mustRunAfter.
For more information, please refer to https://docs.gradle.org/8.14.2/userguide/validation_problems.html#implicit_dependency in the Gradle documentation.
I’m not sure what the proper way is to fix that issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
gRPC
Solution
This PR adds the
samples/grpc-kmp-appproject, a small KMP chat app (including server) that shows how to use the gRPC library.