Skip to content

Introduce binary compatibility validator #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2024
Merged

Introduce binary compatibility validator #169

merged 1 commit into from
Jan 11, 2024

Conversation

Goooler
Copy link
Contributor

@Goooler Goooler commented Jan 5, 2024

Closes #168.

@qurbonzoda qurbonzoda self-requested a review January 10, 2024 10:27
qurbonzoda
qurbonzoda suggested changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@qurbonzoda qurbonzoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest validating public declarations in the kotlinx.collections.immutable.internal package as well. Otherwise, LGTM

@Goooler Goooler force-pushed the binary-api-validator branch from 14e03a2 to 96c952e Compare January 10, 2024 10:33
@qurbonzoda qurbonzoda merged commit 3ea58c0 into Kotlin:master Jan 11, 2024
@qurbonzoda
Copy link
Contributor

Thanks for the contribution!

@Goooler Goooler deleted the binary-api-validator branch January 11, 2024 13:08
@Goooler Goooler mentioned this pull request Apr 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@qurbonzoda qurbonzoda qurbonzoda requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce Binary compatibility validator to track API changes
2 participants
@Goooler @qurbonzoda