Use BCV version compatible w/ Kotlin 2.1 #186
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Kotlin 2.0 it is provided by stdlib. See KT-57150.
Goooler
reviewed
Jul 18, 2024
| plugins { | ||
| id("kotlinx.team.infra") version "0.4.0-dev-80" | ||
| id("org.jetbrains.kotlinx.binary-compatibility-validator") version "0.13.2" | ||
| id("org.jetbrains.kotlinx.binary-compatibility-validator") version "0.15.0-20240704150100-2.1-SNAPSHOT" |
There was a problem hiding this comment.
Suggested change
| id("org.jetbrains.kotlinx.binary-compatibility-validator") version "0.15.0-20240704150100-2.1-SNAPSHOT" | |
| id("org.jetbrains.kotlinx.binary-compatibility-validator") version "0.16.0" |
There was a problem hiding this comment.
Or we can merge #180 instead.
Comment on lines
+8
to
+9
| maven { url 'https://maven.pkg.jetbrains.space/kotlin/p/kotlinx/dev'} | ||
|
|
There was a problem hiding this comment.
Suggested change
| maven { url 'https://maven.pkg.jetbrains.space/kotlin/p/kotlinx/dev'} |
|
This could be closed for now. Handled by #188. |
qurbonzoda
force-pushed
the
kotlin-community/dev
branch
from
3b28c01 to
38454d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest BCV versions are incompatible with LV 2.1 due to the old
kotlinx-metadata-jvmversion being used.Unfortunately, BCV could not be easily updated (Kotlin/binary-compatibility-validator#241 (comment)).
This PR changes the BCV for
kotlin-commuinity/devbuilds to a snapshot build with ab updated metadata version (built from kotlin-community/stable-metadata branch).