Skip to content

Conversation

shanshin
Copy link
Contributor

Fixes #2717

@shanshin shanshin requested a review from sandwwraith June 20, 2024 15:03
Copy link
Member

@sandwwraith sandwwraith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also pls add dependency on Hocon module to integration-test

build.gradle.kts Outdated
repositories.from(testRepositories)
}

abstract class ArtifactsCheckTask: DefaultTask() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be in a separate file rather than in build.gradle.kts

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, perhaps we can move artifacts.txt from root folder to gradle or something

@shanshin shanshin requested a review from sandwwraith June 21, 2024 15:19
@shanshin shanshin merged commit 3de98ff into dev Jun 24, 2024
@shanshin shanshin deleted the fix-publication branch June 24, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants