Skip to content
This repository was archived by the owner on Jul 31, 2022. It is now read-only.

Fixed issue where file handler would sometimes return null for existing files; Optimized LIVELOAD file handler. #118

Merged
merged 3 commits into from
Nov 17, 2020

Conversation

Katsute
Copy link
Member

@Katsute Katsute commented Nov 16, 2020

Prerequisites

If all checks are not passed then the pull request will be closed.

  • My code follows the style listed in CONTRIBUTING.
  • I have checked that no other similar pull requests already exists.
  • Build compiles.
  • Build runs without exceptions.
  • I have added/modified documentation (if applicable).
  • I have added/modified test cases.

Changes Made

List changes made and/or relevant issues. Please keep changed in reverse chronological order (newest at top).

if(entry == null){ // add new entry if not already added and file exists
final File file = getFile(path);
return file != null && file.exists()
? files.put(context, new FileEntry(file, adapter, loadingOption))
: null;

@Katsute Katsute added the bug Something isn't working as expected label Nov 16, 2020
@Katsute Katsute self-assigned this Nov 16, 2020
@Katsute Katsute added this to the 4.2.0 milestone Nov 16, 2020
Fixed files being added on liveload (this would cause memory issues over time).
@Katsute Katsute added the optimization Optimizations label Nov 16, 2020
@Katsute Katsute changed the title Fixed issue where file handler would sometimes return null for existing files. Fixed issue where file handler would sometimes return null for existing files; Optimized LIVELOAD file handler. Nov 16, 2020
@Katsute Katsute merged commit e35aa59 into main Nov 17, 2020
@Katsute Katsute deleted the fix#117@d15bc78 branch November 17, 2020 00:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working as expected optimization Optimizations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Folder that exists causes file handler to return null file.
1 participant