Skip to content
This repository was archived by the owner on Jul 31, 2022. It is now read-only.

Optimize Context Creation #78

Merged
merged 1 commit into from
Jul 24, 2020
Merged

Optimize Context Creation #78

merged 1 commit into from
Jul 24, 2020

Conversation

Katsute
Copy link
Member

@Katsute Katsute commented Jul 24, 2020

Prerequisites

If all checks are not passed then the pull request will be closed

  • My code follows the style listed in CONTRIBUTING
  • I have checked that no other similar pull requests already exists
  • Build compiles
  • Build runs without exceptions
  • I have added/modified documentation (if applicable)

Changes Made

list changes made and/or relevant issues

  • Single class for context creation/join.
  • Optimized how leading/trailing slashes were added.
  • Optimized how join contexts were created.
  • Added detection for consecutive slashes.
  • Removed redundant checks for backslash when forward slash enforcement is used.
  • Added required tests.
  • Replace 'path' parameter with 'context'

@Katsute Katsute added the optimization Optimizations label Jul 24, 2020
@Katsute Katsute merged commit 344e971 into master Jul 24, 2020
@Katsute Katsute deleted the uniform-contexts@2a0e22f branch July 24, 2020 16:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
optimization Optimizations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant