Skip to content

Small translation changes #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Small translation changes #123

merged 2 commits into from
Aug 24, 2023

Conversation

madkarmaa
Copy link
Member

@madkarmaa madkarmaa commented Aug 24, 2023

+ formatting

- Ricco di funzionalità
- Orientamento ad oggetti
- Facile da usare
- Leggero (ma molto performante)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do these spaces do?

@@ -118,12 +118,14 @@ Poiché Google [alla fine eliminerà gradualmente](https://developer.chrome.com/
1. Salva https://github.com/raw/kudoai/chatgpt.js/main/chatgpt.js in una sottocartella (`lib` in questo esempio)

2. Aggiungi la dichiarazione di esportazione ES6 alla fine di `lib/chatgpt.js`

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When adding newlines after numbered headings, the gap as rendered by Docsify shrinks for some reason. Can you edit the CSS to preserve the prev distance? It will even fix this bug's effect docsifyjs/docsify#2057 (and I can mass-edit the other docs using regex in VSC)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the autosave messed up, I've just noticed, lemme revert the changes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@madkarmaa the newlines? keep them if you edit the CSS (or I can do after my tasks) because it fixes the indent bug's effects as I mentioned

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@madkarmaa also your comment said ' +formatting' so I thought you wanted them?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't check them, autosave usually removes tab spaces on blank lines, so I thought it did that until I checked, my bad

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry you lost me, as you type translations, autosave modified by adding tabs on empty lines? also what is the case and check what

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not just translations. each time I save a file it gets formatted unless I tell vscode not to do it
this time, I forgot to disable it, and so once I saved it changed some formatting in the file
I thought it was nothing important, just like sometimes it removes tabs where they're not needed (eg. empty lines)
so I didn't check but I should've

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because you noted you made formatting changes, so I don't get how it got added by mistake

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw the lines had changed but I thought it was the tabulations thing, so I also said "formatting" but it was a mistake

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok i typed my last reply while your msg before that was invisible beacuse github didn't autoload it, now i got it

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@madkarmaa madkarmaa requested a review from adamlui August 24, 2023 12:06
@adamlui adamlui merged commit 6ab6043 into KudoAI:main Aug 24, 2023
@madkarmaa madkarmaa deleted the translations branch August 24, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants