Add an automatic voxelisation option to PhotonVisibilityService

[bwynneHEP]

Added an automatic voxelisation option, fitting exactly to the TPC boundaries and then optimising for the cryostat

Also added the option to save lists of voxel IDs within the TPC and outside, to allow efficient generation of photon library.

NB, this seems to require a rebuild of larana, specificially due to
https://github.com/LArSoft/larana/blob/b6abb28a9515bb5a8193e6aa2fd131a2ee0ecd8e/larana/OpticalDetector/SimPhotonCounter_module.cc#L192
This seems like a problem with the build system, but maybe I'm missing something obvious.

[FNALbuild]

A new Pull Request was created by @bwynneHEP (Benjamin Wynne) for develop.

It involves the following packages:

larsim

@LArSoft/level-1-managers, @LArSoft/level-2-managers can you please review it and eventually sign? Thanks.

cms-bot commands are listed here

[FNALbuild]

The code-checks are being triggered in jenkins.

[FNALbuild]

-code-checks
Pull request failed code-formatting checks. Please ensure that cetmodules has been setup and execute the following command from the top-level directory of your repository:

format-code \
  larsim/PhotonPropagation/PhotonVisibilityService.cc \ 
  larsim/PhotonPropagation/PhotonVisibilityService.h

Then commit the changes and push them to your PR branch.

[FNALbuild]

Pull request #135 was updated. @LArSoft/level-1-managers, @LArSoft/level-2-managers can you please check and sign again.

[FNALbuild]

The code-checks are being triggered in jenkins.

[FNALbuild]

+code-checks

[knoepfel]

@bwynneHEP, thanks for the PR. We are trying to understand the motivation for these changes--could you give us some background information? Presenting this at a LArSoft Coordination Meeting could be helpful.

Regarding the larana build issue--a rebuild is required of any downstream code that includes this service as a header and/or links against the corresponding library.

[bwynneHEP]

@knoepfel the motivation is simply convenience. The context is generating samples for the "photon library," but perhaps this has more general application.

We want a voxel grid that covers the cryostat efficiently, with boundaries that align to the TPC so that it is easy to label a voxel as inside or outside the TPC. All these dimensions can be looked up, and a voxelisation calculated and added to a configuration file, but it's far quicker and more reliable to just calculate it directly in the PVS from the existing geometry description. Also this includes a simple optimisation step that would otherwise add complexity to the apparently back-of-an-envelope guesswork used before.

The output lists of voxel indices inside or outside the TPC then simplifies sorting jobs and outputs for large-scale production of samples.

[bwynneHEP]

I should also note that all this behaviour defaults to off - there is no modification to existing workflows. Any effects would only be felt at configuration time, if the behaviour is enabled.

[knoepfel]

@bwynneHEP, sorry for the delay, and thanks for the response. The idea seems reasonable. I will send some implementation suggestions later this week.

[knoepfel]

@bwynneHEP, I've added some implementation suggestions for your consideration. I'm happy to discuss any of them with you.

[FNALbuild]

Pull request #135 was updated. @LArSoft/level-1-managers, @LArSoft/level-2-managers can you please check and sign again.

[FNALbuild]

Pull request #135 was updated. @LArSoft/level-1-managers, @LArSoft/level-2-managers can you please check and sign again.

[FNALbuild]

The code-checks are being triggered in jenkins.

[FNALbuild]

+code-checks

[bwynneHEP]

Apologies for spam, minor git fail. Comments should now be incorporated, thanks @knoepfel

[knoepfel]

trigger build

[FNALbuild]

The tests are being triggered in jenkins.

[FNALbuild]

+LArSoft tests OK on slf7 for c14:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/22553&builds=
+build

[FNALbuild]

+LArSoft tests OK on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/22554&builds=
+build

[FNALbuild]

-uboone tests failed on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:uboone/view_builds/index?offset=0&builds=uboone_ci/10541&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/22554&builds=

[bwynneHEP]

-uboone tests failed on slf7 for e26:prof for details see https://lar-ci-history.fnal.gov/LarCI/app/ns:uboone/view_builds/index?offset=0&builds=uboone_ci/10541&builds= for details of the parent CI build see https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/22554&builds=

The uBOONE fails seem to be unrelated to code changes

135: ----------- check this block for errors -----------------------
136: Error encountered when setting up product: larpandora
137: ERROR: Version conflict -- dependency tree requires versions conflicting with current setup of product larpandora: version v09_22_01 vs v09_22_04
138: ERROR: setup -B larpandora v09_22_01 -q e26:+prof failed
139: ERROR: setup of required products has failed

[FNALbuild]

-sbnd tests warning, with build warning,, with ignored warning for build, on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:sbnd/view_builds/index?offset=0&builds=sbnd_ci/14103&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/22554&builds=

[FNALbuild]

-icarus tests warning on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:icarus/view_builds/index?offset=0&builds=icarus_ci/9779&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/22554&builds=

[FNALbuild]

-dune tests tests warning on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:dune/view_builds/index?offset=0&builds=dune_ci/17141&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/22554&builds=

[tomjunk]

Approved -- looks okay and defaults to no change in workflows.

[lgarren]

approve

[FNALbuild]

This pull request is fully signed and it will be merged to develop and built in the next LArSoft release after it passes the integration tests.