Skip to content

Conversation

CharlesPignerol
Copy link
Contributor

…ical entities in user preferences.

@nicolaslg nicolaslg force-pushed the topocolor_preferences_fix1 branch from 734a194 to a9e418c Compare October 6, 2025 08:15
@nicolaslg
Copy link
Collaborator

I detected two issues that should be fixed in commit 6ee9b94

  • there is typo where topoColorWith1DProj.getGreen is taken to detect color change for oldTopoColorWith2DProj
  • color of entities of lower dimension projection onto higher dimension entities was not updated (ex. the color display of edges associated to surfaces was not updated when the 2D projection color changed)

Sorry for the delay in reviewing the PR

@CharlesPignerol
Copy link
Contributor Author

@nicolaslg Thank you for your careful proofreading and corrections ;)

Charles PIGNEROL and others added 2 commits October 8, 2025 01:56
…not updated; green component for 2D projection change detection wrongly took the 1D value
@nicolaslg nicolaslg force-pushed the topocolor_preferences_fix1 branch from 6ee9b94 to 4c4a626 Compare October 8, 2025 06:56
@nicolaslg nicolaslg self-requested a review October 8, 2025 07:42
@nicolaslg nicolaslg merged commit 1376ace into main Oct 8, 2025
2 checks passed
@nicolaslg nicolaslg deleted the topocolor_preferences_fix1 branch October 8, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants