Always use getAABB for fence bounds #478
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Resolves #477 and resolves #446
Proposed Changes
This PR changes the
getFenceBounds
function to usegetAABB
for all types of skins, as opposed to just bitmap skins.Reason for Changes
getFastBounds
does different things depending on external state, leading to inconsistent behavior.It is also incompatible with Scratch 2.0, which fences all sprites, including vector ones, based on their AABB.
Test Coverage
I've added a fencing test which ensures fencing is the same before and after "if on edge, bounce" (which calls
getBounds
internally) is called.