Should Skin.getFenceBounds ever call getFastBounds?

[adroitwhiz]

Expected Behavior

Skin.getFenceBounds() is used to determine how far a drawable can move off-stage, and so it should return a consistent value.

Actual Behavior

Skin.getFenceBounds() calls drawable.getFastBounds(), which returns different values depending on whether the drawable's convex hull exists. While this behavior is overridden in BitmapSkin, SVGSkin retains it.

I'm not sure whether this could ever become a practical problem. Is it supposed to happen/okay?

[griffpatch]

Could this explain scratchfoundation/scratch-vm#2076 or scratchfoundation/scratch-vm#2078

…

On Tue, 23 Apr 2019, 12:19 adroitwhiz, ***@***.***> wrote: Expected Behavior Skin.getFenceBounds() is used to determine how far a drawable can move off-stage, and so it should return a consistent value. Actual Behavior Skin.getFenceBounds() calls drawable.getFastBounds(), which returns different values depending on whether the drawable's convex hull exists. While this behavior is overridden in BitmapSkin, SVGSkin retains it. I'm not sure whether this could ever become a practical problem. Is it supposed to happen/okay? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#446>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABTM3PQBV4ZXUBMQ2VADGLLPR3WDPANCNFSM4HHW7HYA> .