Tests: Convert Swift tests to use Testing module where possible #1202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADKaster
force-pushed
the
swift-testing-see-make
branch
2 times, most recently
from
a27f4b7 to
3d5b920
Compare
Merged
2 tasks
ADKaster
commented
Aug 28, 2024
Instead of using a global setting, let's set this per-target. This prevents conflicts when importing third-party dependencies that do not tolerate the mode being "default".
ADKaster
force-pushed
the
swift-testing-see-make
branch
from
3d5b920 to
331ba4c
Compare
This project is a part of the Xcode-shipped toolchain on macOS, but needs built from source on other platforms. However, using the Xcode version of the framework leads to a bunch of rpath confusion when trying to link it the expected way. I suspect that there will be a more intuitive way to link this library from the toolchain when it stabilizes. So we'll build it everywhere :)
The AK tests can't seem to use it because it crashes the frontend :)
ADKaster
force-pushed
the
swift-testing-see-make
branch
from
331ba4c to
0d82314
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the upcoming standard swift-testing library as a dependency.
In theory, this library will be included in the swift toolchain. Until that plan is finalized and stabilized for both Linux and macOS, pull it from GitHub using FetchContent.
The Testing.framework shipped with Xcode 16 Beta 5 links against libraries in /usr/lib/swift that only exist in the Developer/ and toolchain sections of the Xcode app, and not on my macOS installation. It also doesn't seem to be added to the rpath of our applications, as it lives in the Xcode Developer directories instead of in the system path. As such, we'll keep building it for macOS from source until the swift-testing maintainers come up with a good way to use the library from CMake, as the current focus is the Swift Package Manager.
The Xcode-shipped Testing.framework can be used if the developer sets USE_XCODE_TESTING_LIBRARY to ON in FindSwiftTesting.cmake and calls our test module like so: