Skip to content

feat: remove other props in actions type inference #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2019

Conversation

stkevintan
Copy link

fix type inference problem:
image

@Brooooooklyn Brooooooklyn requested a review from runjuu June 25, 2019 06:23
@runjuu
Copy link
Contributor

runjuu commented Jun 25, 2019

Seems there has some type issues when run yarn run lint

image

@stkevintan
Copy link
Author

stkevintan commented Jun 26, 2019

@runjuu I'm afraid I just encounter a ts 3.4.x bug, related issue: ksxnodemodules/typescript-tuple#8

It only affect lint, but not in the IDE or compile, I have no clue to fix it by now.....

Maybe downgrade the ts version can solve the error.

@stkevintan
Copy link
Author

@runjuu I finally figure out how to solve the annoying typescript 3.4+ recursive types error. please review the updated code.

图片

@runjuu
Copy link
Contributor

runjuu commented Jun 27, 2019

@stkevintan Nice work! 🍻Thanks

@runjuu runjuu merged commit 049bc62 into LeetCode-OpenSource:master Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants