-
Notifications
You must be signed in to change notification settings - Fork 0
List channel interpreters #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are editing the right files. Can you add a test in Lib/test/test_xxsubinterpreters.py
to test the low level function.
Also, I suggest that you open a PR on CPython for this low-level functionality. I would love to see If other core developers review it before I pull it for use in the high-level PEP 554 implementation. Just exclude the changes to the high level interpreters module as this is PEP 554 related work and not yet upstream. @ericsnowcurrently what do you think?
Thanks for taking a look Joannah. I'm happy to have a go at writing some tests - there's also some finishing off needed in the implementation, I was just wanting to check the implementation is along the right lines (i.e. providing a I'll tidy up the diff (drop the PEP-554 stuff) and make a PR to upstream cpython when it's all been finalised - at this point I just wanted to check it's 'roughly correct' before spending more time on it! |
d968282
to
e4b26ed
Compare
8822816
to
168ebf3
Compare
…nto list-channel-interps
WIP for ericsnowcurrently/multi-core-python#52