Skip to content

List channel interpreters #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 28 commits into from
Closed

List channel interpreters #3

wants to merge 28 commits into from

Conversation

LewisGaul
Copy link
Owner

Copy link

@nanjekyejoannah nanjekyejoannah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are editing the right files. Can you add a test in Lib/test/test_xxsubinterpreters.py to test the low level function.

Also, I suggest that you open a PR on CPython for this low-level functionality. I would love to see If other core developers review it before I pull it for use in the high-level PEP 554 implementation. Just exclude the changes to the high level interpreters module as this is PEP 554 related work and not yet upstream. @ericsnowcurrently what do you think?

@LewisGaul
Copy link
Owner Author

Thanks for taking a look Joannah.

I'm happy to have a go at writing some tests - there's also some finishing off needed in the implementation, I was just wanting to check the implementation is along the right lines (i.e. providing a channel_list_interpreters(chan_id, send_or_receive) function to be called from the channel classes in interpreters.py).

I'll tidy up the diff (drop the PEP-554 stuff) and make a PR to upstream cpython when it's all been finalised - at this point I just wanted to check it's 'roughly correct' before spending more time on it!

@LewisGaul LewisGaul force-pushed the list-channel-interps branch 2 times, most recently from d968282 to e4b26ed Compare November 20, 2019 11:38
@LewisGaul LewisGaul force-pushed the list-channel-interps branch from 8822816 to 168ebf3 Compare November 21, 2019 12:00
@LewisGaul LewisGaul changed the base branch from nanjekye-subinterpreters to master November 21, 2019 12:02
@LewisGaul LewisGaul closed this Dec 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants