Modernization efforts

[rtfarte]

• Add generics
• Add try-with-resource options
• Use foreach instead of iterators
• Lambdas and streams?
• Maintain backwards compatibility

[fvbassi]

I also would like to have the library updated to be type safe and use all the "modern" features of Java 8.
I volunteer to update the project to use the aforementioned features, if needed.

This will very likely break the current interface, because lots of non-typed parameters in the interface are exposed in the public API.
Is there a specific branch I should start from? (Maybe a 1.4.x version)

[andreasrosdal]

Pull-requests to modernize OpenPDF are welcome!

This will very likely break the current interface

We can not break the current interface (API) of OpenPDF. The project currently has a goal to be compatible with iText 2.x and 4.x. We can add new classes, but not break the current API now.

[fvbassi]

Do you think is it possible to change public methods from
public ArrayList getChunks();
to
public ArrayList<Chunk> getChunks();
?

[andreasrosdal]

@fvbassi Yes, I think changing public methods in ways so that it will still work for existing users should be possible. This doesn't break the API, I think, since the users of the getChunks() are expecting an ArrayList with Chunk objects, so the code calling the library will still compile and work.

Make sure that OpenPDF will still work for existing users. I think we need the opinions of many other OpenPDF developers and users of OpenPDF before making such changes, though.
Pull-requests welcome!

[rtfarte]

One possible solutions would be to create new, generic-enabled classes that extend the functionality. Another possibility could be to add new methods that accept generics.

I believe that returning generics on existing classes is acceptable. Is the only concern for methods that accept a generic list or updating a class to be generic?

I also think that adding try-with-resource should not affect any current clients of the library.

[andreasrosdal]

I believe that returning generics on existing classes is acceptable

Let's start with this. Pull-requests are welcome!

I also think that adding try-with-resource should not affect any current clients of the library

Also a very good idea!

[fvbassi]

Let me work on it. I'm facing some difficulties, but I'm still on track. Let me create a proposal. We will then discuss some details.

…

On Fri, Jan 25, 2019 at 5:09 AM Andreas Rosdal ***@***.***> wrote: I believe that returning generics on existing classes is acceptable Let's start with this. Pull-requests are welcome! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#139 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AsybxREVO6BqG74Hu4DVooxSag85aw9Fks5vGoNdgaJpZM4aDXyK> .

[andreasrosdal]

@fvbassi I've seen that you have done a lot of good work in your own fork on the modernization of OpenPDF. Perhaps you could submit a pull-request soon, so we can include your changes?

[fvbassi]

Let me have a bit more time to cleanup few details... I don't feel comfortable with a couple of things. And I also want to do some testing. –fb Il giorno ven 15 feb 2019, 11:43 AM Andreas Rosdal <notifications@github.com> ha scritto:

…

@fvbassi <https://github.com/fvbassi> I've seen that you have done a lot of good work in your own fork on the modernization of OpenPDF. Perhaps you could submit a pull-request soon, so we can include your changes? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#139 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AsybxU-MbZho5esbQZmtdksolqJz8EBVks5vNo9OgaJpZM4aDXyK> .

[fvbassi]

Sorry... You are right. Let me open a PR for these changes. I will fix other things in a subsequent one: unfortunately in these week I can't work on it. I will highlight in the PR a couple of problems that are hard to solve without breaking the API: * the class Phrase (and another one that I can't remember), used to extend ArrayList (as a contained of the children elements). This is mostly impossible to keep, because if we change the signature to be "class Phrase extends ArrayList<Element>", this will make some bridge method clash. So, I removed ArrayList<> as a superclass and added it as a field. But this may break the compatibility, due to the methods implicitely exported from the class ArrayList. Let me now try to learn how to open my first pull request! – fb

…

On Tue, Feb 26, 2019 at 7:26 AM Andreas Rosdal ***@***.***> wrote: @fvbassi <https://github.com/fvbassi> Any news? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#139 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AsybxakdeP0k2t6LIpSaZwrBR37WDqOMks5vRNOOgaJpZM4aDXyK> .

[fvbassi]

I should have already created one, last week. Let me check... Il lun 4 mar 2019, 7:38 AM Andreas Rosdal <notifications@github.com> ha scritto:

…

@fvbassi <https://github.com/fvbassi> Any news? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#139 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AsybxWBkpzbuZGf-Wn7RLQVy_jxTh0WHks5vTL-BgaJpZM4aDXyK> .