Skip to content

logging module collision #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hadim opened this issue Jan 29, 2020 · 1 comment
Closed

logging module collision #766

hadim opened this issue Jan 29, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@hadim
Copy link
Contributor

hadim commented Jan 29, 2020

Logging module collides with the Python one:

import pytorch_lightning as pl
dir(pl.logging)

It gives you the python logging module attributes instead of the pytorch_lightning ones.

This is probably due to this https://github.com/PyTorchLightning/pytorch-lightning/blob/deffbaba7ffb16ff57b56fe65f62df761f25fbd6/pytorch_lightning/__init__.py#L31

Maybe you should rename the logging module to something else such as logger?

@hadim hadim added the bug Something isn't working label Jan 29, 2020
@hadim
Copy link
Contributor Author

hadim commented Jan 29, 2020

duplicate #731

@hadim hadim closed this as completed Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant