Skip to content

Fix backwards compatibility for optional logging dependencies #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2020

Conversation

tullie
Copy link
Contributor

@tullie tullie commented Feb 19, 2020

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
  • Did you read the contributor guideline?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Fixes #798, #799 and #815

There's other ways to fix this, but I felt that adding these redirect files was the simplest and easiest to understand.

@pep8speaks
Copy link

pep8speaks commented Feb 19, 2020

Hello @tullie! Thanks for updating this PR.

Line 2:101: E501 line too long (103 > 100 characters)

Line 2:101: E501 line too long (103 > 100 characters)

Line 2:101: E501 line too long (103 > 100 characters)

Line 2:101: E501 line too long (103 > 100 characters)

Line 2:101: E501 line too long (103 > 100 characters)

Comment last updated at 2020-02-20 00:40:03 UTC

@tullie tullie requested a review from Borda February 19, 2020 19:58
@Borda Borda added bug Something isn't working need fix labels Feb 19, 2020
@Borda Borda added this to the 0.6.1 milestone Feb 19, 2020
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Borda Borda added the ready PRs ready to be merged label Feb 19, 2020
@tullie tullie closed this Feb 20, 2020
@tullie tullie reopened this Feb 20, 2020
@williamFalcon williamFalcon merged commit 897def2 into Lightning-AI:master Feb 21, 2020
@williamFalcon
Copy link
Contributor

@tullie thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optional dependencies are required for deprecated logging module
4 participants