Skip to content
This repository was archived by the owner on Feb 17, 2021. It is now read-only.

create sample app to test cocoapods integration #125

Merged

Conversation

jingwei-huang1
Copy link
Contributor

@jingwei-huang1 jingwei-huang1 commented Apr 12, 2017

  • Create Package.swift to prepare swift package manager integration
  • Move LayoutKit to Source folder to prepare swift package manager integration
  • Create test project by using LayoutKitSampleApp
  • Use cocoapods to integrate LayoutKitSampleApp
  • Update build script to test cocoapods integration

@jingwei-huang1 jingwei-huang1 force-pushed the create-sample-app-to-test-cocoapods-integration branch 3 times, most recently from 38c09c5 to 1333b6f Compare April 13, 2017 00:02
@jingwei-huang1 jingwei-huang1 self-assigned this Apr 13, 2017
@jingwei-huang1
Copy link
Contributor Author

@nicksnyder @staguer This PR is hard to review and I moved this branch to LayoutKit from my folk repo. So please check it out and review locally.

@jingwei-huang1 jingwei-huang1 force-pushed the create-sample-app-to-test-cocoapods-integration branch from 1333b6f to df2feae Compare April 13, 2017 23:55
@staguer
Copy link
Contributor

staguer commented Apr 14, 2017

The top level directories include:
Example
ExampleLayouts
Source
LayoutKitTests

This makes it seem like examples and tests aren't source code. I mentioned this in an earlier comment.

What do you think about structuring the directories like so:
Source/ExampleApp
Source/ExampleLayouts
Source/LibraryTests
Source/Library

Copy link
Contributor

@staguer staguer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you haven't yet, please verify that this automated test does indeed fail if a mistake is introduced.


# Run test on tvOS
rm -rf $DERIVED_DATA &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment explaining why the order Derived Data clearing is important.

Copy link
Collaborator

@nicksnyder nicksnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't have a chance to pull and test, but I didn't see any obvious problems. As Sergei said, just make sure that this does indeed fail if a error is introduced in the podspec

@jingwei-huang1 jingwei-huang1 force-pushed the create-sample-app-to-test-cocoapods-integration branch from df2feae to 9deb7b5 Compare April 17, 2017 20:29
@jingwei-huang1 jingwei-huang1 force-pushed the create-sample-app-to-test-cocoapods-integration branch from 9deb7b5 to 41e7329 Compare April 17, 2017 20:53
@jingwei-huang1 jingwei-huang1 merged commit 2df3a70 into master Apr 17, 2017
@jingwei-huang1 jingwei-huang1 deleted the create-sample-app-to-test-cocoapods-integration branch April 17, 2017 21:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants