Skip to content

Conversation

tomlau10
Copy link
Contributor

The default severity when running CLI --check is incorrectly set to 'Warning' if the diagnostics.severity config table is incomplete.

This will fix #2730 .

@tomlau10 tomlau10 force-pushed the bugfix/cli_default_severity branch from a329e7e to 0f64ab1 Compare June 26, 2024 08:06
@carsakiller carsakiller added the feat/diagnostics Related to the diagnostics feature label Jun 26, 2024
@tomlau10 tomlau10 force-pushed the bugfix/cli_default_severity branch from 0f64ab1 to 917bdfe Compare June 26, 2024 15:59
@carsakiller carsakiller self-requested a review June 26, 2024 19:37
@sumneko sumneko merged commit 3886d2e into LuaLS:master Jun 27, 2024
@sumneko
Copy link
Collaborator

sumneko commented Jun 27, 2024

Thank you!

@tomlau10 tomlau10 deleted the bugfix/cli_default_severity branch June 27, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat/diagnostics Related to the diagnostics feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using diagnostics.severity setting in .luarc.json seems to break the severity level filtering in generated report
3 participants