-
-
Notifications
You must be signed in to change notification settings - Fork 354
Ar/typecheckfix #693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ar/typecheckfix #693
Conversation
… for operand 1 and operand2 are integer or number
我觉得可以明确一下规则: 上面这个规则我晚点改一下试试 |
自定义的类型都是table,那如果是alias呢,如果我用 |
vm.getDocDefines |
好的。 |
if not typeName then | ||
return false | ||
elseif typeNameMap[typeName] | ||
or infer.isInnerType(typeName) then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isInnerType 被我删掉了,因为我发现已经在 define.lua 里实现过了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
看起来是写错了,我改一下
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
现在改用 vm.isBuiltinType
来判断
add skynet meta
delete some variables not in skynet and alias a skynet message handler
…e-server into ar/typecheckfix
请问我这个pr可以合吗?不知道为什么我今天合了master之后重新push上来,这个pr把很多并不是我的改动给diff出来了。 |
不可以把master合到你自己的分支里的 |
好的。 |
merge操作其实是丢弃掉另一侧的提交,然后由你来重新提交一遍。之后在PR的时候就会像现在这样出现别人的提交。 |
哦哦好的 |
string.match
的返回值类型m.searchInfers
临时增加了一个返回值以标识是否是class并且也是table,这是临时的,之后可以回退