Skip to content

Converting integration tests to EF Core #3881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 11, 2022
Merged

Converting integration tests to EF Core #3881

merged 4 commits into from
Feb 11, 2022

Conversation

jbogard
Copy link
Contributor

@jbogard jbogard commented Jan 31, 2022

One step towards allowing xplat/*nix-based development

Fixes #3521

@jbogard jbogard requested a review from lbargaoanu January 31, 2022 16:17
@jbogard
Copy link
Contributor Author

jbogard commented Jan 31, 2022

Both CreateDatabaseIfNotExists and DropCreateDatabaseAlways don't exist in EF Core so I created ones that do similar - drop and create. Technically CreateDatabaseIfNotExists also drops the database but I think all tests should drop and create anyway.

lbargaoanu
lbargaoanu reviewed Jan 31, 2022
View reviewed changes
@jbogard
Copy link
Contributor Author

jbogard commented Feb 11, 2022

@lbargaoanu can you review this? I can click the red button but would rather not :)

lbargaoanu
lbargaoanu approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@lbargaoanu lbargaoanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think we need to refactor to a base class, but we can do that anytime.

@jbogard jbogard merged commit f0635d2 into master Feb 11, 2022
@jbogard jbogard deleted the efcore branch February 11, 2022 18:35
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2022
@lbargaoanu lbargaoanu added this to the 12.0.0 milestone Aug 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@lbargaoanu lbargaoanu lbargaoanu approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
12.0.0
Development

Successfully merging this pull request may close these issues.

EF Core integration tests
2 participants
@jbogard @lbargaoanu