Fix Issue #4502 - Confusing exception when trying to map types with … #4503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

lbargaoanu merged 1 commit into LuckyPennySoftware:seal_mappers from Biotronic:Fix-4502

Oct 3, 2024

Biotronic commented Oct 2, 2024 •

edited by lbargaoanu

Loading

…in parameters in ctor

Fixes #4502.

Contributor

lbargaoanu commented Oct 2, 2024

Revart all the whitespace changes. Assert that the test mapping actually works.

lbargaoanu reviewed

View reviewed changes

src/AutoMapper/Internal/TypePair.cs Outdated Show resolved Hide resolved

lbargaoanu reviewed

View reviewed changes

src/AutoMapper/ConstructorMap.cs Outdated Show resolved Hide resolved

LuckyPennySoftware deleted a comment from Biotronic

lbargaoanu marked this pull request as draft

October 2, 2024 17:00

lbargaoanu reviewed

View reviewed changes

src/UnitTests/Bug/ByrefConstructorParameter.cs Outdated Show resolved Hide resolved

Biotronic force-pushed the Fix-4502 branch 2 times, most recently from 4d49084 to 616f4bd Compare

October 2, 2024 18:39

Biotronic changed the title ~~Fix Issue #4502 - Confusing exception when trying top map types with …~~ Fix Issue #4502 - Confusing exception when trying to map types with …

lbargaoanu reviewed

View reviewed changes

src/AutoMapper/Internal/TypePair.cs Outdated Show resolved Hide resolved

lbargaoanu reviewed

View reviewed changes

src/AutoMapper/ConstructorMap.cs Outdated Show resolved Hide resolved

Biotronic force-pushed the Fix-4502 branch from 616f4bd to 195e81f Compare

October 2, 2024 19:42

lbargaoanu changed the base branch from master to seal_mappers

October 3, 2024 04:32

lbargaoanu closed this

lbargaoanu reopened this

Contributor

lbargaoanu commented Oct 3, 2024 •

edited

Loading

Try the MyGet build.


          Fix Issue LuckyPennySoftware#4502 - Confusing exception when trying t…

980e66f

…op map types with in parameters in ctor

lbargaoanu force-pushed the Fix-4502 branch from 195e81f to 980e66f Compare

October 3, 2024 05:04

lbargaoanu marked this pull request as ready for review

October 3, 2024 05:05

lbargaoanu merged commit b4331bb into LuckyPennySoftware:seal_mappers

2 checks passed

lbargaoanu linked an issue

that may be closed by this pull request

Confusing exception when trying top map types with in parameters in ctor #4502

Closed

lbargaoanu added the Improvement label

lbargaoanu added this to the 14.0.0 milestone

Biotronic deleted the Fix-4502 branch

October 3, 2024 07:25

Author

Biotronic commented Oct 3, 2024

Works beautifully. :)

github-actions bot commented Nov 10, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels