Skip to content

修复点击启动服务器不跳转到终端界面的bug #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 11, 2023
Merged

修复点击启动服务器不跳转到终端界面的bug #122

merged 4 commits into from
Sep 11, 2023

Conversation

kitUIN
Copy link
Contributor

@kitUIN kitUIN commented Sep 10, 2023

🐛switchTo有时并不会跳转到终端界面

修改如下:

  • 使用setCurrentItem进行跳转
  • 同意Eula也将自动启动服务器并且跳转

@LxHTT
Copy link
Collaborator

LxHTT commented Sep 10, 2023

  1. 改用setCurrentItem后，原方法可删除。
  2. Eula同意后直接开启的逻辑您修改错了。。我的建议是w（即对话框）的确定按钮点击信号（即w.yesSignal.connect(self. startServer) 到启动服务器的方法，这样就会重新走一次检查eula的流程然后因为有eula=true了就直接启动了

@LxHTT
Copy link
Collaborator

LxHTT commented Sep 10, 2023

已作修改。如果您还有问题可提出，不然我明天晚上可能就合并了（

@LxHTT LxHTT self-assigned this Sep 10, 2023
@LxHTT LxHTT added · 功能建议 新功能建议/新平台适配等 ❓需要测试 需要大众测试/需要更多人手 等待反馈者 等待反馈者的回复 · 程序Bug 需要修复的程序错误！ labels Sep 10, 2023
@kitUIN
Copy link
Contributor Author

kitUIN commented Sep 10, 2023

还有另一个
🐛下载页面更改核心而不置空构建列表
当选择过一个核心和版本的时候,构建列表内存在项,此时如果切换核心,将不会置空构建列表

修改如下:

  • 选择核心的时候,删除构建列表内所有项

@LxHTT
Copy link
Collaborator

LxHTT commented Sep 10, 2023 •
edited
Loading

ok的
测试ok吗

@kitUIN
Copy link
Contributor Author

kitUIN commented Sep 10, 2023

ok的 测试ok吗

测试正常,但建议您也测一遍

@LxHTT LxHTT merged commit c1df737 into MCSLTeam:master Sep 11, 2023
@LxHTT
Copy link
Collaborator

LxHTT commented Sep 11, 2023

测试通过

@LxHTT LxHTT added 完成 这个东西已经OK了 and removed ❓需要测试 需要大众测试/需要更多人手 等待反馈者 等待反馈者的回复 labels Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@LxHTT LxHTT

Labels
· 功能建议 新功能建议/新平台适配等 · 程序Bug 需要修复的程序错误！ 完成 这个东西已经OK了
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kitUIN @LxHTT