Skip to content

Fix unsupported file_cache_maxsize for older xarray #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2019
Merged

Fix unsupported file_cache_maxsize for older xarray #506

merged 1 commit into from
Jan 10, 2019

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Jan 8, 2019

Older versions of xarray are not supported after #501, which is undesirable and unnecessary. All that is needed to fix this is to not raise and exception if file_cache_maxsize is not supported in a given xarray version.

closes #505

@xylar xylar added the bug label Jan 8, 2019
@xylar xylar self-assigned this Jan 8, 2019
@xylar xylar requested a review from milenaveneziani January 8, 2019 10:00
@xylar
Copy link
Collaborator Author

xylar commented Jan 8, 2019

@milenaveneziani, could you verify that this fixes the issue you had?

@xylar xylar mentioned this pull request Jan 8, 2019
Closed
@xylar
Copy link
Collaborator Author

xylar commented Jan 8, 2019 •
edited
Loading

Testing

I successfully ran the analysis on simulation (20181203.GMPAS-DIB-IAF.T62_oEC60to30v3wLI.edison) on cori using e3sm-unified v. 1.2.4.

@xylar xylar added the priority label Jan 8, 2019
milenaveneziani
milenaveneziani approved these changes Jan 9, 2019
View reviewed changes
Copy link
Collaborator

@milenaveneziani milenaveneziani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran a test with develop again and it failed. Re-ran the test with this branch and all worked fine.

@xylar xylar merged commit 89419e6 into MPAS-Dev:develop Jan 10, 2019
@xylar xylar deleted the fix_file_cache_maxsize branch January 10, 2019 07:03
@xylar
Copy link
Collaborator Author

xylar commented Jan 10, 2019

Thanks, @milenaveneziani!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milenaveneziani milenaveneziani milenaveneziani approved these changes

Assignees

@xylar xylar

Labels
bug priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error on last commit (remove autoclose)
2 participants
@xylar @milenaveneziani