Skip to content
This repository was archived by the owner on Feb 15, 2023. It is now read-only.

BLD: update commit hashes to point at tip of scipy mckib2:gcc48to52 #110

Closed
wants to merge 1 commit into from

Conversation

mckib2
Copy link

@mckib2 mckib2 commented Jan 18, 2021

@@ -2,7 +2,7 @@ env:
global:
- REPO_DIR=scipy
# Also see DAILY_COMMIT below
- BUILD_COMMIT=ab1c0907f
- BUILD_COMMIT=68eb089
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few thoughts here:

  1. Why not open the PR against master? Unless there's a special reason to do otherwise, we'd normally do that and backport from there if we really need a backport.
  2. If you really want to build your specific feature branch, you can try setting BUILD_COMMIT to the name of your feature branch (if you open a PR against master you'll notice that BUILD_COMMIT points at master.
  3. I don't see anything special about your feature branch at the moment in terms of things the wheels repo would care about--I assume your plan is to make meaningful changes in that feature branch in response to any issues that crop up here in the wheels repo.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tylerjereddy Thanks, I think with your feedback I understand what's going on a little bit better.

  1. Yes, I can open a new PR against master
  2. If I open a PR against master, does DAILY_COMMIT need to change to the branch name? or do I just need to make BUILD_COMMIT=mckib2:boost?
  3. I was pointing to the wrong branch -- I will need to point to the actual feature branch that we need testing for (ENH: Boost stats distributions scipy/scipy#13328) and modify the scripts here to use gcc5 and then mirror those changes in mckib2:gcc48to52 if any are needed

I will open a new PR tomorrow, thanks!

@mckib2 mckib2 closed this Jan 18, 2021
@tylerjereddy
Copy link
Collaborator

tylerjereddy commented Jan 18, 2021 via email

@rgommers
Copy link
Contributor

@mckib2 in your new PR, you may want to delete .travisci.yml to avoid triggering TravisCI until other CI systems are happy - we're very short on TravisCI credits.

@mckib2
Copy link
Author

mckib2 commented Jan 19, 2021

@rgommers Yes, I can do that. I ran out of time today, hopefully tomorrow I can another PR open and try again.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants