Stop renaming the nightly wheels by adding date-time to them #118
Conversation
| # Get a less shallow clone; needed to get the commit count since | ||
| # the previous release branch point right. | ||
| git: | ||
| depth: 3000 |
There was a problem hiding this comment.
You could use false to disable the depth restriction.
There was a problem hiding this comment.
Yeah I know, I chose not to because I only need the commits till the last branch point. Getting all 25,000 of them can be quite slow.
There was a problem hiding this comment.
3,000 should be enough for any minor release period I think.
azure-posix.yml
Outdated
| @@ -114,7 +113,6 @@ jobs: | |||
| - bash: | | |||
| set -e | |||
| if [ $ANACONDA_ORG == "scipy-wheels-nightly" ]; then | |||
| source extra_functions.sh | |||
| for f in wheelhouse/*.whl; do rename_wheel $f; done | |||
There was a problem hiding this comment.
The if statement should probably be deleted.
There was a problem hiding this comment.
Ah yes. Me and bash aren't friends:(
There was a problem hiding this comment.
I note there is also a rename_wheel in .travis.yml.
There was a problem hiding this comment.
Correction, only for f in wheelhouse/*.whl; do rename_wheel $f; done still needs to be removed. The if also encompasses the upload.
There was a problem hiding this comment.
It didn't encompass the upload, all removed now.
The rename makes the metadata inconsistent with the filename, and pip 21 refuses to install such wheels after downloading them. The reason for the rename was to get regularly incrementing version numbers so the newest nightly in the wheelhouse is picked first. This is now fixed in SciPy master.
|
The |
|
Good catch, done.
Indeed, but some other time - I've already invested way too much time in CI issues in the past week. I think it could use a bigger overhaul actually, right now I just want to get it green and fix bug where nightlies are not installable. |
|
OT: Is there a reason to keep using appveyor? NumPy does the windows builds on azure. It is also easy to add a cron job to travis, daily, weekly, and monthly are options. |
|
TravisCI and Azure are happy, Appveyor is untouched in this PR - so let's call it good, in it goes.
Not really, just inertia. |
Renaming is bad, it causes a mismatch between file name and
METADATAinside the wheel. This is the cause of gh-114. scipy/scipy#13882 should have removed the need for this renaming, it prepends a monotonously increasing number (commit count since previous branch point for a minor version).Closes gh-114.