Skip to content

Conversation

abishekve
Copy link
Collaborator

No description provided.

@abishekve abishekve changed the title pr: optimize endpointService by applying windowStart filter in database perf: optimize endpointService by applying windowStart filter in database Sep 20, 2025
@abishekve abishekve changed the title perf: optimize endpointService by applying windowStart filter in database perf: optimize endpointService by applying windowStart filter in database and set the MaxConcurrentProbes to 20 Sep 20, 2025
@abishekve abishekve self-assigned this Sep 20, 2025
Copy link
Member

@hemanandr hemanandr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check with the logic that we are not converting from epoch to DateTime for the filtering purpose -

.OrderByDescending(o => ConvertToDateTimeOffset(o.StartedTs))
var outages = await _context.Outages
.Where(o => o.EndpointId == id &&
o.StartedTs <= DateTimeOffset.UtcNow.ToUnixTimeSeconds() &&
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we check the StartedTS to be less than the DateTimeOffset now this will always pass ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants