Skip to content

Update nlargest nsmallest doc #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 63 commits into
base: main
Choose a base branch
from
Open

Update nlargest nsmallest doc #1

wants to merge 63 commits into from

Conversation

MainHanzo
Copy link
Owner

Copy link

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Some minor requests / nits.

@rhshadrach
Copy link

Sorry @MainHanzo - I didn't realize this was a PR on your fork. I can make these comments on pandas-dev#56369 if it'd be helpful. Let me know.

jorisvandenbossche and others added 28 commits December 6, 2023 21:30
* BUG: Series.__mul__ for pyarrow strings

* Fix existing tests

* Another test
…andas-dev#56281)

* BUG: Fix `Timestamp('now')` and `Timestamp.now` unit inconsistency

* Move return

* Update doc/source/whatsnew/v2.1.4.rst

Co-authored-by: Matthew Roeschke <[email protected]>

* Resolve

* not use tuple in cython for perf

---------

Co-authored-by: Matthew Roeschke <[email protected]>
* TYP: require_matching_freq

* mypy fixup
…6123)

* BUG: ne comparison returns False for NA and other value

* Fix

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: Thomas Li <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…s-dev#56160)

* BUG: reset_index not preserving object dtype for string option

* Fixup

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: Thomas Li <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* DOC: Add release date for 2.1.4

* DOC: Add release date for 2.1.4
* BUG: Index.str.cat casting result always to object

* Update accessor.py

* Fix further bugs

* Fix

* Update accessor.py

* Update v2.1.4.rst

* Update v2.2.0.rst
)

* Adjust tests in extension folder for new string option

* Fix typing

* Update setitem.py
* CLN: Remove unnecessary copy keyword

* CLN: Remove unnecessary copy keyword

* Fixup
* BUG: resample with ArrowDtype

* Typing

* xfail for windows

* Fix again?

* Avoid tuple

* Add gh numbers
…dev#56106)

* Fix string option tests in indexing

* Update v2.1.4.rst

* Fixup

* Update whatsnew
* Compiled pandas with -Wextra

* np_datetime_strings.c fallthrough

* test fixes

* win compat

* win compat again?

* size_t arg fixup

* casts

* size_t fixes

* more size_t fix

* json fixes

* builtin Py_UNUSED
* STY: Fix doctest and docstring formatting errors

* ensure stderr is output too

* Fix more failures

* Don't add redirects for single page, fix example

* A few more

* Remove e flag
jbrockmendel and others added 27 commits December 9, 2023 10:57
* outer join on equal indexes to sort by default

* whatsnew

* fix test

* remove Index._join_precedence
…ndas-dev#56365)

* Keep series names when not ignoring them

* Split test into two shorter tests

* whatsnew

* tolist

* Split test for concat on index
* Start fixing string tests

* BUG: interpolate raising wrong error for ea

* Fix more tests

* REGR: join segfaulting for arrow string with nulls

* Fix more tests

* Fix more tests

* BUG: rank raising for arrow string dtypes

* BUG: eq not implemented for categorical and arrow backed strings

* More tests

* BUG: ndim of string block incorrect with string inference

* Fix test

* Fix tests

* Fix tests

* Fix more indexing tests

* BUG: Index.insert raising when inserting None into new string dtype

* Fix tests

* BUG: Inserting ndim=0 array does not infer string dtype

* Fix tests

* Fix tests

* Fix more tests

* Fix more tests

* BUG: idxmax raising for arrow strings

* Fix

* Fix more tests

* Fix more tests

* Fix more tests

* Fix remaining tests

* Fix remaining tests

* Change default

* BUG: Groupby not keeping string dtype for empty objects

* Start fixing gb tests

* Fix tests

* Merge main

* Update config_init.py

* Fixup

* Update
…dev#56047)

* BUG: read_csv not respecting object dtype when option is set

* Update readers.py

* Cover str too

* Adjust

* Fixup

* Fixup

* Update readers.py
* BUG: setitem casting object Index to arrow strings

* Fix

* Start fixing index tests

* BUG: Index.isin raising for arrow strings and null set

* Fix more tests

* TST: Fix shares_memory for arrow string dtype

* TST: Fix shares_memory for arrow string dtype

* TST: Fix shares_memory for arrow string dtype

* Fix more tests

* BUG: Index.getitem returning wrong result with negative step for arrow

* Update

* Update

* Fix

* Update array.py

* Fix

* Move

* Move

* Fix

* Add gh ref

* Update v2.1.4.rst

* Finish

* Update

* Update test_base.py

* Update test_old_base.py

* Update conftest.py

* Update conftest.py

* Update test_old_base.py

* Update

* Update test_setops.py

* Fix pre-commit
* Adjust tests in strings folder for new string option

* BUG: translate losing object dtype with new string dtype

* Fix

* BUG: Index.str.cat casting result always to object

* Update accessor.py

* Fix further bugs

* Fix

* Fix tests

* Update accessor.py
* Adjust tests in array directory for new string option

* BUG: value_counts not preserving object dtype

* Adjust tests in array folder for new string option

* Fixup

* Fix

* Fix

* Revert "BUG: value_counts not preserving object dtype"

This reverts commit f570a4f
)

* ENH: Make get_dummies return ea booleans for ea inputs

* ENH: Make get_dummies return ea booleans for ea inputs

* Update

* Update pandas/tests/reshape/test_get_dummies.py

Co-authored-by: Thomas Baumann <[email protected]>

* Update test_get_dummies.py

* Update test_get_dummies.py

* Fixup

---------

Co-authored-by: Thomas Baumann <[email protected]>
Bumps [actions/stale](https://github.com/actions/stale) from 8 to 9.
- [Release notes](https://github.com/actions/stale/releases)
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
- [Commits](actions/stale@v8...v9)

---
updated-dependencies:
- dependency-name: actions/stale
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4 to 5.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v4...v5)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Improve error message and add test

* Remove empty line

* update

* Fix line length

* Update test_indexing.py

* Add spaces

* Remove changes in test_indexing.py

* Update base.py
* rename test_period_asfreq->test_period

* TST: de-duplicate PeriodIndex constructor tests
* DEPR: make_block

* lint fixup
…ev#56341)

* Improved test coverage for Styler.bar error conditions

* Fixed the code style issue causing test failure

* Fixed a Styler.bar bug of missing value

* Adopted another tricky way to fix the bug

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Added a test for Styler.bar with pyarrow

* Updated with code style

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: pd.Series.nlargest(keep='all') does not ignore duplicates when counting the largest values