Skip to content

Fix the settings ops schedule toolbar #9505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2025
Merged

Fix the settings ops schedule toolbar #9505

merged 1 commit into from
Aug 6, 2025

Conversation

GilbertCherrie
Copy link
Member

@GilbertCherrie GilbertCherrie commented Jun 23, 2025 •
edited
Loading

This bug was found by @asirvadAbrahamVarghese

Fix the settings ops toolbar to not display while in the schedule form, similar to the other forms on the ops page.

Before:
Screenshot 2025-06-23 at 4 01 28 PM
Screenshot 2025-06-23 at 4 02 02 PM

After:
Still has the configuration button outside of the form.
Screenshot 2025-06-23 at 4 03 56 PM
Screenshot 2025-06-23 at 4 03 52 PM

No configuration button inside of the form.
Screenshot 2025-06-23 at 4 00 15 PM
Screenshot 2025-06-23 at 4 00 36 PM

@GilbertCherrie GilbertCherrie requested a review from a team as a code owner June 23, 2025 20:04
@GilbertCherrie GilbertCherrie requested a review from Fryguy June 23, 2025 20:05
Fryguy
Fryguy reviewed Jun 24, 2025
View reviewed changes
@Fryguy
Copy link
Member

Fryguy commented Jun 24, 2025 •
edited
Loading

I don't understand how @edit and locals can suddenly not be there anymore. locals in particular is a parameter.

Fryguy
Fryguy reviewed Jun 24, 2025
View reviewed changes
Fryguy
Fryguy reviewed Jun 24, 2025
View reviewed changes
@GilbertCherrie GilbertCherrie force-pushed the fix_ops_schedule_toolbar branch from 9a50365 to f09376c Compare June 25, 2025 15:58
@GilbertCherrie GilbertCherrie force-pushed the fix_ops_schedule_toolbar branch from f09376c to 691a738 Compare June 25, 2025 15:59
@GilbertCherrie
Copy link
Member Author

@Fryguy I fixed the issues with the pr if you can review it again

@miq-bot
Copy link
Member

miq-bot commented Jun 25, 2025

Checked commit GilbertCherrie@691a738 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.62.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@Fryguy Fryguy merged commit 66865b8 into ManageIQ:master Aug 6, 2025
18 checks passed
@GilbertCherrie GilbertCherrie deleted the fix_ops_schedule_toolbar branch August 6, 2025 16:18
asirvadAbrahamVarghese added a commit to asirvadAbrahamVarghese/manageiq-ui-classic that referenced this pull request Aug 13, 2025
@asirvadAbrahamVarghese
Revert "Merge pull request ManageIQ#9505 from GilbertCherrie/fix_ops_…
0c0c00a 
…schedule_toolbar"

This reverts commit 66865b8, reversing
changes made to aa78d86.
@jrafanie jrafanie mentioned this pull request Aug 13, 2025
Merged
jrafanie added a commit that referenced this pull request Aug 13, 2025
@jrafanie
Merge pull request #9553 from asirvadAbrahamVarghese/revert-9505-pr
88fc015 
Revert "Merge pull request #9505"
This was referenced Aug 13, 2025
Merged
Merged
Merged
Open
Open
Merged
Merged
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fryguy Fryguy Fryguy approved these changes

+1 more reviewer

@asirvadAbrahamVarghese asirvadAbrahamVarghese asirvadAbrahamVarghese approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Fryguy Fryguy

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GilbertCherrie @Fryguy @miq-bot @asirvadAbrahamVarghese