Skip to content

Conversation

JasonGrace2282
Copy link
Member

@JasonGrace2282 JasonGrace2282 commented Jul 3, 2024

Closes #3837

Example of Bug

>>> from manim import config
>>> config.movie_file_extension
'.mp4'
>>> config.format = "webm"
>>> config.movie_file_extension
'.mp4'
>>> config.transparent = config.transparent
>>> config.movie_file_extension
'.webm'

@JasonGrace2282 JasonGrace2282 added the pr:bugfix Bug fix for use in PRs solving a specific issue:bug label Jul 3, 2024
@JasonGrace2282 JasonGrace2282 added this to the v0.19.0 milestone Jul 3, 2024
@JasonGrace2282 JasonGrace2282 changed the title Fix config.format not updated movie file extension Fix :attr:.ManimConfig.format not updating movie file extension Jul 3, 2024
Copy link
Member

@behackl behackl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@behackl
Copy link
Member

behackl commented Jul 12, 2024

should we add a test for this?

@JasonGrace2282
Copy link
Member Author

Good idea, I'm not sure how I forgot that :)

("mp4", ".mp4"),
("webm", ".webm"),
("mov", ".mov"),
("gif", ".mp4"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is somewhat odd how differently we are treating the case of .gif, but that's a different discussion.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's just a missed edge case, probably worth fixing (wow we have a lot of problems with ManimConfig xD)

@behackl behackl merged commit 628a545 into ManimCommunity:main Jul 13, 2024
@JasonGrace2282 JasonGrace2282 deleted the fix-config branch July 14, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:bugfix Bug fix for use in PRs solving a specific issue:bug

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Suffix of generated video file is incorrect when passing --format

2 participants