Skip to content

Popup remains open after zoom to here link is clicked #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
prushforth opened this issue May 19, 2023 · 0 comments · Fixed by #841
Closed

Popup remains open after zoom to here link is clicked #855

prushforth opened this issue May 19, 2023 · 0 comments · Fixed by #841
Labels
bug

Comments

@prushforth
Copy link
Member

Steps to reproduce:

Go to this experiment
Click on a marker, popup opens
Click on zoom to here link
Click Alt+LeftArrow to return to previous viewport
Observed result:
Popup is still open

Expected result:
No popup should be open
@prushforth prushforth added the bug label May 19, 2023
@prushforth prushforth mentioned this issue May 19, 2023
Merged
5 tasks
AliyanH added a commit to AliyanH/MapML.js that referenced this issue May 19, 2023
@AliyanH
close popup on zoom to here link, closes Maps4HTML#855
8ae334b
@AliyanH AliyanH linked a pull request May 19, 2023 that will close this issue
map-feature bug fixes #841
Merged
5 tasks
prushforth pushed a commit to prushforth/MapML.js that referenced this issue Jun 23, 2023
@AliyanH @prushforth
map-feature bug fixes (Maps4HTML#841)
cecced3 
* remove map-feature bug

* fix/update Event implementation

* stopPropagation attempt

* Finalize map-feature Event handling

* revert index.html

* Add test for stopPropagation

* update observed attributes + add test for click method

* remove non-standard event parameter for click,focus,blur methods

* add support/link for keyup+keydown event

* close popup on zoom to here link, closes Maps4HTML#855
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

map-feature bug fixes AliyanH/MapML.js
1 participant
@prushforth