-
Notifications
You must be signed in to change notification settings - Fork 16
map-feature bug fixes #841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good simplifications, and they seem reliable.
I would have liked to get rid of the click(ev), focus(ev) and blur(ev) parameter, as it seems non-standard, but perhaps that's not possible because we have got leaflet handling the underlying clicks and displaying popups and so on. |
noticed another issue just now that I will work on, removing a map-feature when it is unchecked does not work (can be handled in a separate issue). |
I think this is good to go @prushforth , just a few changes I added:
|
Would you mind fixing this bug in this PR? If that doesn't make sense, feel free to merge this, it looks and works well. |
I like the test for preventDefault that displays a different thing than the popup for the polygon, good idea there. It tests the API and not just our API; that's exactly what we need to do more of. |
* remove map-feature bug * fix/update Event implementation * stopPropagation attempt * Finalize map-feature Event handling * revert index.html * Add test for stopPropagation * update observed attributes + add test for click method * remove non-standard event parameter for click,focus,blur methods * add support/link for keyup+keydown event * close popup on zoom to here link, closes Maps4HTML#855
closes #838