test: Add coordinator consistency checks #21717
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit extends the catalog consistency checks by adding a consistency check for the Coordinator in-memory state. This consistency check is run as a soft-assert after catalog transactions. However, it's not run after testdrive tests, or other catalog check locations, since we don't have easy access to the Coordinator.
5 tasks
andrewrodriguez-m
added a commit
that referenced
this pull request
Sep 27, 2023
Piggybacking on #21717, adding consistency checks to the coordinator that get run in dev and during testdrive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit extends the catalog consistency checks by adding a consistency check for the Coordinator in-memory state. This consistency check is run as a soft-assert after catalog transactions. However, it's not run after testdrive tests, or other catalog check locations, since we don't have easy access to the Coordinator.
Motivation
This PR adds a feature that has not yet been specified.
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.