Skip to content

Conversation

rjobanp
Copy link
Contributor

@rjobanp rjobanp commented Mar 21, 2024

Motivation

  • This PR fixes a previously unreported bug.

In #26186 I found that the dyncfg implementation for storage was broken and ALTER SYSTEM SET <flag> <val> commands would not work since the dyncfg option field in StorageParameters was mistakenly 'taken' before being propagated through downstream storage configuration update commands.

This is a cherry-pick of the first commit in that PR to make the fix in for the release. The tests in that PR confirm the fix.

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:

@rjobanp rjobanp requested review from guswynn and a team March 21, 2024 15:50
@guswynn guswynn added the release-blocker Critical issue that should block *any* release if not fixed label Mar 21, 2024
Copy link
Contributor

@guswynn guswynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yikes

I tested before I changed this based on some code review

@rjobanp rjobanp enabled auto-merge March 21, 2024 15:55
@rjobanp rjobanp merged commit 43497f8 into MaterializeInc:main Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-blocker Critical issue that should block *any* release if not fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants