config: add sslmode verify-ca and verify-full
#2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a connection is established, the added modes are treated in the same way as the existing `require` mode as they both require a TLS connection.
Adds additional SSL config params: - sslcert - sslkey - sslrootcert More details at https://www.postgresql.org/docs/9.5/libpq-connect.html#LIBPQ-CONNSTRING.
This was referenced May 20, 2021
benesch
approved these changes
May 20, 2021
petrosagg
approved these changes
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I first tried to solve this on the Materialize side by parsing and "cleaning" the connection string before handing it to the Postgres client, but it added quite a bit of parsing complexity (e.g. connection strings come in URL and param list format, params can be quoted, there are escape sequences).
I think that having these additions in our fork is the simplest and most robust way of doing it without adding too much of a maintenance burden (the touched files should not change frequently). In addition, there is a discussion on the upstream client repo to contribute these changes upstream.