Skip to content

Switching to ESM (and upgrading dependencies) #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 18, 2024
Merged

Conversation

CMCDragonkai
Copy link
Member

@CMCDragonkai CMCDragonkai commented Dec 18, 2024

Description

Turns out @matrixai/contexts can become ESM cause all the dependencies are ESM too.

Issues Fixed

Tasks

  • 1. Update to ESM
  • 2. Update to using flake.nix
  • 3. GitLab to GitHub CI
  • 4. Update to eslint? Given that it's changed in version 9 from Zeta House Docs

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@CMCDragonkai
Copy link
Member Author

To change to GitHub CI involves more than changing the .gitlab-ci.yml to the github equivalent.

There's a bunch of permissions to enable on GitHub.

This includes both the secret permissions here, as well as permission for this repo to access the container image on github otherwise github won't be able to run it.

@CMCDragonkai
Copy link
Member Author

I think in the future @brynblack you should be automating the github access across all the repos using pulumi in the orchestrator. There's too many to be manually setting up all the time.

@tegefaulkes

@CMCDragonkai
Copy link
Member Author

This is a good example to follow to apply to other library repositories @tegefaulkes @brynblack.

@CMCDragonkai CMCDragonkai merged commit 8f2a781 into staging Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to ESM
1 participant