Skip to content

Integrate Canary Check #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2022
Merged

Integrate Canary Check #15

merged 2 commits into from
Apr 11, 2022

Conversation

CMCDragonkai
Copy link
Member

@CMCDragonkai CMCDragonkai commented Apr 11, 2022

Description

This adds a canary root property that is checked for deadbeef string. If it doesn't decrypt, that means the key is wrong, or if the string is not deadbeef, the DB is corrupted.

Issues Fixed

Tasks

  • 1. Added canaryCheck protected method
  • 2. Had to change the _* internal methods to avoid needing to pass db, instead uses this._db and mandates order
  • 3. Closes the LevelDB if the start fails

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@CMCDragonkai CMCDragonkai self-assigned this Apr 11, 2022
@CMCDragonkai CMCDragonkai merged commit aabe10c into master Apr 11, 2022
@CMCDragonkai CMCDragonkai deleted the canary branch April 11, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Integrate Canary Check during DB start
1 participant