Merge latest changes from master
#1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: (32 commits)
RFC: Return type overlap validation
Tests for `NewDirectives()` for better coverage
Clean up redundant code in `completeValueCatchingError` - `completeValue` would already have resolved the value for `func() interface{}`
Add tests for type comparators
Spec compliant @skip/@include.
Fix bug where @include directive is ignored if @Skip is present.
Test that `executor` threads `RootValue` correctly - Similar to `context` test
Improve coercion error messages
[RFC] Add explicit context arg to graphql execution
Add GraphQLSchema types field
Removed logs
Follow up to: Move getTypeOf to executor and rename to defaultResolveTypeFn to mirror defaultResolveFn
Add tests for default resolve function.
Restored deprecated fields in `directives` in introspective query for coverage. Should be removed once `onOperation`, `onFragment`, `onField` are dropped from spec.
Move getTypeOf to execute.js and rename to defaultResolveTypeFn to mirror defaultResolveFn
Remove unused function parameters
Remove unused function parameters
Minor follow-up to graphql-go#311
[RFC] Add Schema Definition to IDL.
Updating schema parser to more closely match current state of RFC
...
commit Matthias247@be39d41 - Running `go test` would have passed previously, but running all tests with `go test ./...` would fail. - Increased coverage for `lexer` package to 100% - Added more tests to cover parsing unicode strings (see graphql-go#135) as well.
…ing type - Removed unnecessary check of length of run in `readName()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update with latest changes from
masterbranch (graphql-go#123)