Remove MBEDTLS_SHA3_C config option

[gabor-mezei-arm]

Description

Replace uses of MBEDTLS_SHA3_C config option with PSA_WANT macros.

Resolve #10203

PR checklist

Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.

• changelog not required
• development PR not required because: this is
• TF-PSA-Crypto PR provided Remove MBEDTLS_SHA3_C config option TF-PSA-Crypto#266
• framework PR not required
• 3.6 PR not required because: 4.0 changes
• tests provided

[felixc-arm]

Generally looks good to me, but I see there's a CI failure saying Error: Test case not executed: test_suite_shax;SHA-3 invalid param. It also seems to be present in the TF-PSA-Crypto patch so I'm not sure if the fix would be here or (more likely) in the TF-PSA-Crypto patch. Otherwise LGTM 🙂

[mpg]

Looks good to me, thanks!

As discussed on the crypto PR, I think we can first merge this without updating the crypto pointer, then merge the crypto PR, and be done with it (no mutual dependency, no follow-up). Can you try removing the commit that updates the crypto pointer? Then if we get a green CI I'll formally approve.

Note: I've compared the error.c files generated before and after this PR, and all the changes look good to me. You've even fixed a minor indentation inconsistency in #if statements, thanks :)

[mpg]

As discussed on the crypto PR, I think we can first merge this without updating the crypto pointer

I see you're still updating the crypto pointer here. Do you disagree with the proposed approach? If so, can you explain what you think I'm missing?

Otherwise, can you push a version of this PR with just the last commit removed (ie keeping all changes except for the submodule update)? If it passes CI that way, we can merge it without waiting for the crypto PR, making things much simpler.

[gabor-mezei-arm]

I see you're still updating the crypto pointer here. Do you disagree with the proposed approach? If so, can you explain what you think I'm missing?

I only want to test the changes of the crypto repo.

[mpg]

I only want to test the changes of the crypto repo.

Ok, makes sense. Note that this can be done by starting a job manually with all the branches you want as parameters: https://mbedtls.trustedfirmware.org/job/mbed-tls-restricted-pr-test-parametrized/build?delay=0sec

Well looks like the CI fully disagrees with my idea that we could get the Mbed TLS PR merged first, without updating the submodule. So, I officially withdraw that suggestion, sorry.

Let's go back to Gille's plan: let's try to get the crypto PR merged first (ie, with a clean CI on its own, not through the companion mbedtls CI). IIRC there was a point where the only CI issue there was check_names.py and we thought we could just pacify it with a dummy #define to be removed later.