Skip to content

Fix error handling _do_request() #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 4, 2025
Merged

Conversation

JanCaha
Copy link
Contributor

@JanCaha JanCaha commented Jul 3, 2025

Fixes how HTTPError is handled in _do_request().

This should fix a lot of errors in plugin and db-sync, or at least provide much better error messages for them.

Fixes MerginMaps/qgis-plugin#642, fixes MerginMaps/qgis-plugin#705 and many others

@JanCaha JanCaha requested a review from MarcelGeo July 3, 2025 09:17
@coveralls
Copy link

Pull Request Test Coverage Report for Build 16050297154

Details

  • 24 of 25 (96.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.06%) to 80.13%

Changes Missing Coverage Covered Lines Changed/Added Lines %
mergin/client.py 10 11 90.91%
Files with Coverage Reduction New Missed Lines %
mergin/client.py 1 86.16%
Totals Coverage Status
Change from base Build 16025346231: 0.06%
Covered Lines: 3456
Relevant Lines: 4313

💛 - Coveralls

@MarcelGeo MarcelGeo merged commit 2440b66 into master Jul 4, 2025
4 of 7 checks passed
@MarcelGeo MarcelGeo deleted the fix-error-handling-_do_request branch July 4, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to sync project [PROJECT_NAME] due to an unhandled exception. Failed to sync project due to an unhandled exception.
3 participants