Explicitly allow creation of MC without auth #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h if it was not provided
Pull Request Test Coverage Report for Build 16317812920Details
💛 - Coveralls |
|
@JanCaha do we need to release this for the upcoming qgis-plugin release? |
|
If we want to solve the SSO auth properly then quite likely yes. I will discuss it tommorow on standup with Stefanos |
MarcelGeo
requested changes
Jul 11, 2025
There was a problem hiding this comment.
Just wondering if this has_auth will be valid after some actions.
I thinks _auth_params is mos important thing, as there is stored username and password.
we can ask also @wonder-sk for 👁️
uclaros
approved these changes
Jul 11, 2025
|
Good point, that makes sense. Renamed. |
MarcelGeo
approved these changes
Jul 15, 2025
|
changed by @wonder-sk requests to drop the decorator and change it to parameter |
wonder-sk
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
@check_tokenon functions that require authorization and not on all requests towards server. That allows some requests like/configand functions related to it to be usable without user being logged.Simplify function
login()not to use custom request logic, but utilizepost()function that is part of MerginClient.Add tests cases.