Override visual object colors with tags #4920
Conversation
source/MRMesh/MRObject.h
Outdated
| /// provides read-only access to the metadata storage | ||
| /// the storage is a set of unique strings | ||
| const std::unordered_set<std::string>& getMetadata() const { return metadata_; } | ||
| /// provides read-write access to the metadata storage | ||
| std::unordered_set<std::string>& getMutableMetadata() { return metadata_; } |
There was a problem hiding this comment.
can both functions be named just tags() ? (also we usually virtualize non-const getters) (for models we have mesh() and varMesh() for example)
There was a problem hiding this comment.
also it seems that set and update functions are required (to set needRedraw_ flag internally)
| @@ -216,6 +216,8 @@ class MRVOXELS_CLASS ObjectVoxels : public ObjectMeshHolder | |||
| /// nullptr means serialize in defaultSerializeVoxelsFormat() | |||
| MRVOXELS_API void setSerializeFormat( const char * newFormat ); | |||
|
|
|||
| MRVOXELS_API void resetFrontColor() override; | |||
source/MRMesh/MRObject.h
Outdated
| /// provides read-only access to the tag storage | ||
| /// the storage is a set of unique strings | ||
| const std::unordered_set<std::string>& getTags() const { return tags_; } | ||
| /// provides read-write access to the tag storage | ||
| std::unordered_set<std::string>& getMutableTags() { return tags_; } |
There was a problem hiding this comment.
getTags -> tags
getMutableTags -> virtual varTags (to be more like existing functions)
source/MRVoxels/MRObjectVoxels.cpp
Outdated
| void ObjectVoxels::resetFrontColor() | ||
| { | ||
| setDefaultColors_(); | ||
| } |
There was a problem hiding this comment.
please add comment in all such places, that we cannot do
setDefaultColors_
{
resetColors();
}
to keep setDefaultColors_ non-virtual and resetColors - virtual
source/MRViewer/MRVisualObjectTag.h
Outdated
| /// add the tag to the object and apply related visual object properties | ||
| MRVIEWER_API static void applyTag( VisualObject& visObj, const std::string& visTagId, bool force = false ); | ||
| /// remove the tag from the object and reset the visual object properties | ||
| MRVIEWER_API static void revertTag( VisualObject& visObj, const std::string& visTagId, bool force = false ); |
source/MRViewer/MRVisualObjectTag.h
Outdated
| /// add the tag to the object and apply related visual object properties | ||
| MRVIEWER_API static void applyTag( VisualObject& visObj, const std::string& visTagId, bool force = false ); |
There was a problem hiding this comment.
mb we should separate add/remove/apply:
for example create add/removeTag functions to MR::Object and call apply on these function via signals or tagApplyCallback registry or something?
| /// update visual object properties according to whether given object has the visual object tag or not | ||
| MRVIEWER_API static void update( VisualObject& visObj, const std::string& visTagId ); |
There was a problem hiding this comment.
should we be able to update all tags present in storage at once?
No description provided.