fix: remove metadata for unsupported keyrings

[mikesposito]

Explanation

When the user vault is decrypted and there is an attempt to restore an unsupported/deprecated/faulty keyring there's no mechanism to remove related metadata, which leads to a situation where no further action can be made on the controller, because checks for keyrings and metadata length will fail.

We can remove the related metadata object when the keyring restore fails.

References

• Fixes Keyring metadata mismatch for unsupported keyrings #5701

Changelog

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
• I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

[mikesposito]

The downside of this solution is that if we consider the following scenario:

• There is some metadata for a keyring
• The keyring fails to restore, for any reason, and metadata will be removed
• The keyring is then supported again

The keyring will then have a different ID, compared to what it had initially. Unfortunately, to avoid this, we'd have to store the metadata along with its keyring in the vault directly.