Skip to content

Chore/optimize submit global pwd #6180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Chore/optimize submit global pwd #6180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
425f477
feat: optimize submitGlobalPassword
lwin-kyaw Jul 24, 2025
a2fa305
Merge remote-tracking branch 'origin/main' into chore/optimize-submit…
lwin-kyaw Jul 24, 2025
3a43961
fix: fixed lint
lwin-kyaw Jul 24, 2025
4aa55b8
chore: updated ChangeLog
lwin-kyaw Jul 24, 2025
8074017
chore: add some comments
lwin-kyaw Jul 24, 2025
0a1c527
feat: reset password outdated cache after sucessful submitGlobalPassword
lwin-kyaw Jul 24, 2025
415e7d8
chore: renamed `submitGlobalPassword` method to `submitGlobalPassword…
lwin-kyaw Jul 24, 2025
a0e6b48
fix: fixed ChangeLog
lwin-kyaw Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/seedless-onboarding-controller/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- Added an optional parameter, `passwordOutdatedCacheTTL` to the constructor params and exported `SecretMetadata` class from the controller.([#6169](https://github.com/MetaMask/core/pull/6169))

### Changed

- Renamed public method `submitGlobalPassword` to `submitGlobalPasswordAndSync`. ([#6180](https://github.com/MetaMask/core/pull/6180))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Renamed public method `submitGlobalPassword` to `submitGlobalPasswordAndSync`. ([#6180](https://github.com/MetaMask/core/pull/6180))
- **Breaking** Renamed public method `submitGlobalPassword` to `submitGlobalPasswordAndSync`. ([#6180](https://github.com/MetaMask/core/pull/6180))


### Removed

- Removed `syncLatestGlobalPassword` from the Controller. ([#6180](https://github.com/MetaMask/core/pull/6180))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Removed `syncLatestGlobalPassword` from the Controller. ([#6180](https://github.com/MetaMask/core/pull/6180))
- **Breaking** Removed `syncLatestGlobalPassword` from the Controller. ([#6180](https://github.com/MetaMask/core/pull/6180))

- Moved the vault syncing to the `submitGlobalPassword` method

## [2.4.0]

### Fixed
Expand Down
Loading
Loading