Skip to content

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Jun 11, 2024

Bump @metamask/json-rpc-engine from v7 to v8.

Related

Blocking

Copy link

socket-security bot commented Jun 11, 2024

Copy link

socket-security bot commented Jun 11, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@metamask/[email protected], npm/@metamask/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@legobeat legobeat force-pushed the deps-json-rpc-engine-8 branch from 10dbad5 to 01fe185 Compare June 11, 2024 05:56
@legobeat
Copy link
Contributor Author

legobeat commented Jun 11, 2024

@SocketSecurity ignore npm/@metamask/[email protected]
@SocketSecurity ignore npm/@metamask/[email protected]

network access ok (note: in reality only the latter is used)

@legobeat
Copy link
Contributor Author

@SocketSecurity ignore npm/@metamask/[email protected]
@SocketSecurity ignore npm/@metamask/[email protected]

new author ok (note: in reality only the latter is used)

@legobeat legobeat marked this pull request as ready for review June 11, 2024 05:58
@legobeat legobeat requested a review from a team as a code owner June 11, 2024 05:58
@legobeat legobeat added the dependencies Pull requests that update a dependency file label Jun 11, 2024
@legobeat legobeat requested review from a team July 10, 2024 00:40
MajorLift

This comment was marked as duplicate.

Copy link
Contributor

@MajorLift MajorLift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Clicked the merge button by mistake, sorry about that.

@legobeat legobeat merged commit f215590 into MetaMask:main Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants