feat: Use sandboxed pages for Snaps execution in MV3 #25171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds ready [2b67003]
Page Load Metrics (55 ± 17 ms)
Bundle size diffs
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25171 +/- ##
========================================
Coverage 65.64% 65.64%
========================================
Files 1367 1367
Lines 54257 54257
Branches 14189 14189
========================================
Hits 35616 35616
Misses 18641 18641 ☔ View full report in Codecov by Sentry. |
FrederikBolding
commented
Jun 10, 2024
app/manifest/v3/chrome.json
Outdated
| @@ -1,6 +1,7 @@ | |||
| { | |||
| "content_security_policy": { | |||
| "extension_pages": "script-src 'self' 'wasm-unsafe-eval'; object-src 'none'; frame-ancestors 'none';" | |||
| "extension_pages": "script-src 'self' 'wasm-unsafe-eval'; object-src 'none'; frame-ancestors 'none';", | |||
| "sandbox": "sandbox allow-scripts; script-src 'self' 'unsafe-inline' 'unsafe-eval'; object-src 'none';" | |||
There was a problem hiding this comment.
This is intended to be stricter than the default policy: https://developer.chrome.com/docs/extensions/reference/manifest/content-security-policy#default_policy
There was a problem hiding this comment.
we could experiment with adding default-src 'none' to these, but I think that could potentially block fetch. Maybe other things. But it'd also block some exfiltration techniques like image URLs
There was a problem hiding this comment.
If we add default-src 'none', we would need something for connect-src * to allow for fetch at least
FrederikBolding
changed the title
Builds ready [b0ad7b6]
Page Load Metrics (52 ± 5 ms)
Bundle size diffs
|
|
Looks great. |
FrederikBolding
force-pushed
the
fb/run-snaps-locally-in-mv3
branch
from
98f0439 to
9c51502
Compare
Mrtenz
approved these changes
Jun 12, 2024
Builds ready [89efe5d]
Page Load Metrics (53 ± 5 ms)
Bundle size diffs
|
GuillaumeRx
approved these changes
Jun 12, 2024
naugtur
reviewed
Jun 13, 2024
| @@ -1,6 +1,7 @@ | |||
| { | |||
| "content_security_policy": { | |||
| "extension_pages": "script-src 'self' 'wasm-unsafe-eval'; object-src 'none'; frame-ancestors 'none';" | |||
| "extension_pages": "script-src 'self' 'wasm-unsafe-eval'; object-src 'none'; frame-ancestors 'none';", | |||
| "sandbox": "sandbox allow-scripts; script-src 'self' 'unsafe-inline' 'unsafe-eval'; object-src 'none'; default-src 'none'; connect-src *;" | |||
There was a problem hiding this comment.
thanks for the default-src!
naugtur
approved these changes
Jun 13, 2024
metamaskbot
added
the
release-12.1.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves the execution of Snaps to a sandboxed page referencing a local HTML file inside the offscreen document when using the MV3 build. This effectively gives us access to
evalwithout hitting the network and should reduce the overhead when booting a Snap (+ allow for Snaps to execute when the user is offline).To support this, this PR introduces some new changes to the manifest as well as the build process. For the build process we simply copy the same iframe bundle currently used in the hosted version to
/dist/chrome/snaps. For the manifest, we add a reference to the sandboxed page and tweak the CSP of the sandbox to be as restrictive as possible (the default is not very strict). Then we can simply point the existing offscreen executor to use the local iframe instead of the remote one.Closes #25250