Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Conversation

squirly
Copy link
Contributor

@squirly squirly commented Sep 22, 2018

Dynamically link to react-native and statically link to jwt dependency

For details on the deprecation see: https://developer.android.com/studio/build/dependencies?utm_source=android-studio#dependency_configurations

Dynamically link to react-native and statically link to jwt dependency

For details on the deprecation see: https://developer.android.com/studio/build/dependencies?utm_source=android-studio#dependency_configurations
@squirly squirly changed the title remove deprecated gradle dependency block calls remove deprecated gradle compile dependency calls Sep 22, 2018
@alexandergoncharov-zz
Copy link
Contributor

alexandergoncharov-zz commented Sep 24, 2018

Hi @squirly ,
Thanks for contributing!

compile "com.facebook.react:react-native:+"
compile 'com.nimbusds:nimbus-jose-jwt:5.1'
}
compileOnly "com.facebook.react:react-native:+"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please clarify why are you using compileOnly here for react-native?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I have seen in other react-native plugins but it seems that, per the linked document, api is the correct method to use.

@squirly
Copy link
Contributor Author

squirly commented Sep 26, 2018

@alexandergoncharov I have updated this PR.

@alexandergoncharov-zz
Copy link
Contributor

Hi @squirly ,

Sorry for this delay.
I investigated it more closer and found that this changes affect users who still using Android Gradle Plugin less than 3.0.0 version. We are trying to support as much users as possible.
But you made good changes and a little later we will return to this PR and finish it. So, your efforts will not be lose.

So, for now I'm going to close this PR but please feel free to reopen it if you have any questions.

Thanks,
Alexander

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants