Replace deprecated 'compile' gradle configuration with 'implementation'

[hyochan]

According to [email protected] default gradle version is now 4.4.

[yuri-kulikov]

Hello @hyochan,
Thanks for contributing!

I'm afraid we still can't merge it. We already had such PR but we decided to wait (while 'compile' works with the latest gradle) to keep backward compatibility as long as possible. Someone, for example, can still use react-native 0.56.1 with the old gradle and the last react-native-code-push version.

[hyochan]

@yuri-kulikov Hi. I think it isn't a good idea because as framework updates, the packages need to update. If you are afraid it isn't backward-compatible, then the users have the choice not to upgrade react-native-code-push version (This could be posted in the readme). In my case, I always have to change this in the local environment because build fails because of this. It isn't forward-compatible (Even when I re-install node_modules). I hoped this to be done for a long time, and I've just created PR because it hasn't been updated for a while.

[yuri-kulikov]

@hyochan you're right and we have plans to make it in the nearest future (probably at the beginning of next year). We'll just reopen and merge it when we are ready.

[hyochan]

Thank you.

[hammadzz]

@yuri-kulikov this is a bit painful that we are holding this in for a few who aren't updating they should need to update for bug fixes. It is now 2019 can we have this in asap?

[yuri-kulikov]

We're merging this. Thanks for contributing!