Skip to content

Fixing Title tags in metadata #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fixing Title tags in metadata #1190

wants to merge 2 commits into from

Conversation

juanpablojofre
Copy link
Contributor

Version(s) of document impacted

  • All versions were affected and all were reviewed independently of the others.

@zjalexander , please review and merge (once validations pass).

@andyleejordan andyleejordan added the in-progress Tag - issue is being worked on by someone label May 3, 2017
@saldana
Copy link
Contributor

saldana commented May 3, 2017

✅ Validation status: passed

File Status Preview URL Details
.gitignore ✅Succeeded
reference/3.0/ISE/Get-IseSnippet.md ✅Succeeded
reference/3.0/ISE/Import-IseSnippet.md ✅Succeeded
reference/3.0/ISE/New-IseSnippet.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/Add-History.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/Add-PSSnapin.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/Clear-History.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/Connect-PSSession.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/Disable-PSRemoting.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/Disable-PSSessionConfiguration.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/Disconnect-PSSession.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/Enable-PSRemoting.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/Enable-PSSessionConfiguration.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/Enter-PSSession.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/Exit-PSSession.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/Export-Console.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/Export-ModuleMember.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/ForEach-Object.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/Functions/Clear-Host.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/Functions/Get-Verb.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/Get-Command.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/Get-Help.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/Get-History.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/Get-Job.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/Get-Module.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/Get-PSSession.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/Get-PSSessionConfiguration.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/Get-PSSnapin.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/Import-Module.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/Invoke-Command.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/Invoke-History.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/New-Module.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/New-ModuleManifest.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/New-PSSession.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/New-PSSessionConfigurationFile.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/New-PSSessionOption.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/New-PSTransportOption.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/Out-Default.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/Out-Host.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/Out-Null.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/Providers/Alias-Provider.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/Providers/Environment-Provider.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/Providers/FileSystem-Provider.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/Providers/FileSystem-Provider/Add-Content-for-FileSystem.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/Providers/FileSystem-Provider/Clear-Content-for-FileSystem.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/Providers/FileSystem-Provider/Get-ChildItem-for-FileSystem.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/Providers/FileSystem-Provider/Get-Content-for-FileSystem.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/Providers/FileSystem-Provider/Get-Item-for-FileSystem.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/Providers/FileSystem-Provider/Remove-Item-for-FileSystem.md ✅Succeeded
reference/3.0/Microsoft.PowerShell.Core/Providers/FileSystem-Provider/Set-Content-for-FileSystem.md ✅Succeeded

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Copy link
Contributor

@zjalexander zjalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i got to 4.0 core invoke-history before github crapped out on me. There's a few encoding errors that got added here where symbols got translated to "?".

options:

  1. checkin as is, scrape after. some of these symbols were nonsense before, and they will continue to be nonsense now.
  2. look for "?" or "??" and:
    a) delete them. the only marginally useful one I found was a copyright symbol which I don't think we actually need.
    b) try and replace them manually. this is a ton of work.

I vote for option 2a), do a second pass looking for the "?" or "??" characters by themselves and getting rid of them.

Slight complication: Some of the .md files are getting treated as binary files, which makes DIFF's harder. I'm worried this has to do with more encoding trouble based on this stackoverflow. The resolution should be to create an "attributes" which has *.md diff in it apparently solves the problem, maybe.

@@ -32,7 +32,7 @@ Import-IseSnippet [-Recurse] -Module <String> [-ListAvailable] [<CommonParameter
## DESCRIPTION
The **Import-IseSnippet** cmdlet imports reusable text "snippets" from a module or a directory into the current session.
The snippets are immediately available for use in Windows PowerShell ISE.
This cmdlet works only in Windows PowerShell® Integrated Scripting Environment (ISE).
This cmdlet works only in Windows PowerShell? Integrated Scripting Environment (ISE).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the copyright symbol got eaten here

@@ -26,7 +26,7 @@ Enable-PSRemoting [-Force] [-SkipNetworkProfileCheck] [-WhatIf] [-Confirm] [<Com
## DESCRIPTION
The **Enable-PSRemoting** cmdlet configures the computer to receive Windows PowerShell remote commands that are sent by using the WS-Management technology.

On Windows Server® 2012, Windows PowerShell remoting is enabled by default.
On Windows Server? 2012, Windows PowerShell remoting is enabled by default.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copyright symbol eaten

@@ -251,7 +251,7 @@ PS C:\> Get-Content $m.Path
GUID="{8FA5064B-8479-4c5c-86EA-0D311FE48875}"
Author="Microsoft Corporation"
CompanyName="Microsoft Corporation"
Copyright="© Microsoft Corporation. All rights reserved."
Copyright="?? Microsoft Corporation. All rights reserved."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copyright symbol eaten, also some other weird thing

@@ -205,7 +205,7 @@ IscsiTarget 4.0
Kds 4.0
Microsoft.PowerShell.Diagnostics 4.0
Microsoft.PowerShell.Host 4.0
Microsoft.PowerShell.Management 4.0…
Microsoft.PowerShell.Management 4.0???
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whole bunch of messed up characters here

@@ -137,7 +137,7 @@ Id Name ComputerName State ConfigurationName Availability

The third command uses the Invoke-Command cmdlet to run a script in the session in the $s variable.The script begins to run and return data, but a network outage occurs that interrupts the session. The user has to exit the session and restart the local computer.
PS C:\> Invoke-Command -Session $s -FilePath \\Server12\Scripts\SharedScripts\New-ADResolve.ps1
Running "New-ADResolve.ps1" ….exit
Running "New-ADResolve.ps1" ???.exit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird symbols

@@ -143,7 +143,7 @@ PS C:\> Get-Content .\Links.csv
113207,about_Aliases113208,about_Arithmetic_Operators113209,about_Arrays113210,about_Assignment_Operators113212,
about_Automatic_Variables113213,about_Break113214,about_Command_Precedence113215,about_Command_Syntax144309,
about_Comment_Based_Help113216,about_CommonParameters113217,about_Comparison_Operators113218,about_Continue113219,
about_Core_Commands113220,about_Data_Section…
about_Core_Commands113220,about_Data_Section???
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird characters

@@ -58,7 +58,7 @@ Server03 279bac28-066a-4646-9497-8fcdcfe9757e AllSi

localhost 0d858009-2cc4-47a4-a2e0-da17dc2883d0 RemoteSigned

?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more encoding nonsense :\

@@ -34,7 +34,7 @@ Import-IseSnippet [-Recurse] -Module <String> [-ListAvailable] [<CommonParameter
## DESCRIPTION
The **Import-IseSnippet** cmdlet imports reusable text "snippets" from a module or a directory into the current session.
The snippets are immediately available for use in Windows PowerShell ISE.
This cmdlet works only in Windows PowerShell® Integrated Scripting Environment (ISE).
This cmdlet works only in Windows PowerShell? Integrated Scripting Environment (ISE).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copyright symbol

@@ -28,7 +28,7 @@ Enable-PSRemoting [-Force] [-SkipNetworkProfileCheck] [-WhatIf] [-Confirm] [<Com
## DESCRIPTION
The **Enable-PSRemoting** cmdlet configures the computer to receive Windows PowerShell remote commands that are sent by using the WS-Management technology.

On Windows Server® 2012, Windows PowerShell remoting is enabled by default.
On Windows Server? 2012, Windows PowerShell remoting is enabled by default.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copyright symbol

@@ -272,7 +272,7 @@ PS C:\> Get-Content $m.Path
GUID="{8FA5064B-8479-4c5c-86EA-0D311FE48875}"
Author="Microsoft Corporation"
CompanyName="Microsoft Corporation"
Copyright="© Microsoft Corporation. All rights reserved."
Copyright="?? Microsoft Corporation. All rights reserved."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird characters

@saldana
Copy link
Contributor

saldana commented May 4, 2017

❌ Validation status: errors

File Status Preview URL Details
❌Error Details

  • [Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/PowerShell/PowerShell-Docs, working directory: W:\4p2u-s, target branch: staging, target branch commit: ecd84b0, source branch: jpjofre-I1188, source branch commit: .

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@andyleejordan andyleejordan removed the in-progress Tag - issue is being worked on by someone label May 4, 2017
@juanpablojofre juanpablojofre deleted the jpjofre-I1188 branch May 4, 2017 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants